Fix out-of-bounds read in BinaryReaderLogging::WriteIndent#2795
Merged
Conversation
The remainder write passed indent_ instead of the leftover count i, so once the log indent grew past the static space buffer it read off the end. Use i, matching WatWriter::WriteIndent.
sbc100
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found with ASan while feeding fuzz-style modules to
wasm-objdump --debug:WriteIndent emits the indent from a fixed 142-space buffer in chunks. The loop writes full blocks and shrinks
i; the leftover write then passedindent_, the whole width, rather thani. Once the indent grows past the buffer that leftover write runs off the end.WatWriter::WriteIndentuses the same loop but writes the leftover count, so this was the odd one out.How the indent gets that big: it rises by two on every section Begin. A custom
namesection whose sub-section size runs past the section end fails afterBeginNamesSection, and objdump reads withstop_on_first_errorandfail_on_custom_section_errorboth off, so the matching End callbacks never run and the indent leaks a little per bad section. Enough of them and it passes the buffer during the prepass logging.Regression test added under test/binary-reader; it overruns without the change and is clean with it.